# HG changeset patch # User Michael Pavone # Date 1615185831 28800 # Node ID 45c4b74e7676cd814130af03b802c71d7dd3adaa # Parent 33f454232aeedaac1fe21f840d9ae08ed6aee45b Fix bug in handling of MMAP_CODE regions smaller than 16KB diff -r 33f454232aee -r 45c4b74e7676 backend.c --- a/backend.c Sun Mar 07 10:41:35 2021 -0800 +++ b/backend.c Sun Mar 07 22:43:51 2021 -0800 @@ -56,13 +56,23 @@ if (size_sum) { *size_sum = 0; } + uint32_t minsize; + if (flags == MMAP_CODE) { + minsize = 1 << (opts->ram_flags_shift + 3); + } else { + minsize = 0; + } address &= opts->address_mask; for (memmap_chunk const *cur = opts->memmap, *end = opts->memmap + opts->memmap_chunks; cur != end; cur++) { if (address >= cur->start && address < cur->end) { return cur; } else if (size_sum && (cur->flags & flags) == flags) { - *size_sum += chunk_size(opts, cur); + uint32_t size = chunk_size(opts, cur); + if (size < minsize) { + size = minsize; + } + *size_sum += size; } } return NULL; @@ -269,13 +279,15 @@ uint32_t ram_size(cpu_options *opts) { uint32_t size = 0; + uint32_t minsize = 1 << (opts->ram_flags_shift + 3); for (int i = 0; i < opts->memmap_chunks; i++) { if (opts->memmap[i].flags & MMAP_CODE) { - if (opts->memmap[i].mask == opts->address_mask) { - size += opts->memmap[i].end - opts->memmap[i].start; + uint32_t cursize = chunk_size(opts, opts->memmap + i); + if (cursize < minsize) { + size += minsize; } else { - size += opts->memmap[i].mask + 1; + size += cursize; } } } diff -r 33f454232aee -r 45c4b74e7676 backend_x86.c --- a/backend_x86.c Sun Mar 07 10:41:35 2021 -0800 +++ b/backend_x86.c Sun Mar 07 22:43:51 2021 -0800 @@ -299,10 +299,16 @@ retn(code); } if (memmap[chunk].flags & MMAP_CODE) { + uint32_t added_offset; if (memmap[chunk].mask == opts->address_mask) { - ram_flags_off += (memmap[chunk].end - memmap[chunk].start) / (1 << opts->ram_flags_shift) / 8; ; + added_offset = (memmap[chunk].end - memmap[chunk].start) / (1 << opts->ram_flags_shift) / 8; } else { - ram_flags_off += (memmap[chunk].mask + 1) / (1 << opts->ram_flags_shift) / 8;; + added_offset = (memmap[chunk].mask + 1) / (1 << opts->ram_flags_shift) / 8; + } + if (added_offset) { + ram_flags_off += added_offset; + } else { + ram_flags_off += 1; } } if (lb_jcc) {