# HG changeset patch # User Mike Pavone # Date 1368080961 25200 # Node ID a57fac5b3d6545fae611270e347ce366860dc908 # Parent 8dcc9d14413c5c585ffd0e4a446fbdae97ca2320 Contrary to the official documenation, OR and AND also set PV based on parity instead of overflow diff -r 8dcc9d14413c -r a57fac5b3d65 z80_to_x86.c --- a/z80_to_x86.c Wed May 08 23:20:41 2013 -0700 +++ b/z80_to_x86.c Wed May 08 23:29:21 2013 -0700 @@ -678,7 +678,7 @@ dst = mov_irdisp8(dst, 0, CONTEXT, zf_off(ZF_N), SZ_B); //TODO: Implement half-carry flag if (z80_size(inst) == SZ_B) { - dst = setcc_rdisp8(dst, CC_O, CONTEXT, zf_off(ZF_PV)); + dst = setcc_rdisp8(dst, CC_P, CONTEXT, zf_off(ZF_PV)); dst = setcc_rdisp8(dst, CC_Z, CONTEXT, zf_off(ZF_Z)); dst = setcc_rdisp8(dst, CC_S, CONTEXT, zf_off(ZF_S)); } @@ -707,7 +707,7 @@ dst = mov_irdisp8(dst, 0, CONTEXT, zf_off(ZF_N), SZ_B); //TODO: Implement half-carry flag if (z80_size(inst) == SZ_B) { - dst = setcc_rdisp8(dst, CC_O, CONTEXT, zf_off(ZF_PV)); + dst = setcc_rdisp8(dst, CC_P, CONTEXT, zf_off(ZF_PV)); dst = setcc_rdisp8(dst, CC_Z, CONTEXT, zf_off(ZF_Z)); dst = setcc_rdisp8(dst, CC_S, CONTEXT, zf_off(ZF_S)); }